Variable name fix in python tutorial #6769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `write_client` to `client`, because subsequent tutorials refer to the object as such.
There was a problem hiding this comment.
@spicydonkey Thanks for contributing.
write_client is a local variable name that is used to initialize the write client. This variable is used in the next step of the tutorial (see code below), so replacing it to client would break the set up flow.
I think it's better to keep the variable as write_client to differentiate it from the query_client variable that is used in the later steps of the tutorial (see code below):
ui/src/homepageExperience/components/steps/python/ExecuteQuerySql.tsx
Lines 35 to 43 in 73f0cde
|
I was just about to open this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
write_clienttoclient, because subsequent tutorials refer to the object as such.The single change in varname is in the "code snippet" of the python tutorial InitializeClient at
src/homepageExperience/components/steps/python/InitializeClient.tsx.This is consistent with all code snippets in the subsequent examples.